Skip to content

style: cookie doman => cookie domain #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2022
Merged

style: cookie doman => cookie domain #4919

merged 2 commits into from
Mar 1, 2022
+2 −2

Conversation

edvincent
Copy link
Contributor

While troubleshooting #4900, we got a nice smile from this typo ;)

@edvincent edvincent requested a review from a team February 26, 2022 03:50
@jsjoeio jsjoeio self-assigned this Feb 28, 2022
@jsjoeio jsjoeio added this to the 4.0.3 milestone Feb 28, 2022
jsjoeio
jsjoeio approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me laugh 😂 whoops. Thanks for fixing!

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #4919 (5d5bdee) into main (44d74c1) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4919   +/-   ##
=======================================
  Coverage   69.96%   69.96%           
=======================================
  Files          29       29           
  Lines        1655     1655           
  Branches      364      364           
=======================================
  Hits         1158     1158           
  Misses        423      423           
  Partials       74       74
Impacted Files Coverage Δ
src/node/http.ts 68.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d74c1...5d5bdee. Read the comment docs.

@jsjoeio jsjoeio merged commit b3cf4c3 into coder:main Mar 1, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@edvincent @jsjoeio @TinLe
style: cookie doman => cookie domain (coder#4919)
03fdbf2 
Co-authored-by: Joe Previte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edvincent @jsjoeio